-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delegate body validation #4897
delegate body validation #4897
Conversation
🦋 Changeset detectedLatest commit: e0d8621 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The only reason this is drafted is because I was planning to include some documentations for the types section, if the docs can wait in another and/or this looks good enough as-is, feel free to mark it as ready. |
Wow, this is clever! Personally I don't know that we need to document this — the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart!
A continuation to #1997 (comment), TypeScript implicitly infers index signature for type aliases, hence why we got an error when using it with interfaces.
That's why to counteract those differences, we'd need to wrap the interfaces with
Typify
helper for the index signature workaround, but I guess we could also have us wrap it directly in our types without any visible downsides, yet.Closes #1997
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0