Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate body validation #4897

Merged
merged 10 commits into from
May 13, 2022
Merged

Conversation

ignatiusmb
Copy link
Member

A continuation to #1997 (comment), TypeScript implicitly infers index signature for type aliases, hence why we got an error when using it with interfaces.

That's why to counteract those differences, we'd need to wrap the interfaces with Typify helper for the index signature workaround, but I guess we could also have us wrap it directly in our types without any visible downsides, yet.

Closes #1997

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2022

🦋 Changeset detected

Latest commit: e0d8621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ignatiusmb
Copy link
Member Author

The only reason this is drafted is because I was planning to include some documentations for the types section, if the docs can wait in another and/or this looks good enough as-is, feel free to mark it as ready.

@Rich-Harris
Copy link
Member

Wow, this is clever! Personally I don't know that we need to document this — the name BodyValidator is self-explanatory, and anyone curious about the definition can see it at /docs/types#additional-types-bodyvalidator

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

@Rich-Harris Rich-Harris marked this pull request as ready for review May 13, 2022 17:08
@Rich-Harris Rich-Harris merged commit b162290 into master May 13, 2022
@Rich-Harris Rich-Harris deleted the fix-1997/delegate-body-validation branch May 13, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use interfaces to type endpoint outputs
4 participants