-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate sourcemaps #5258
Generate sourcemaps #5258
Conversation
🦋 Changeset detectedLatest commit: a0e4333 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Can we make this configurable? (It should probably be configurable for Vercel as well.) Not everyone wants to expose their entire human-readable frontend codebase to the world, comments and all. |
I believe this is only being done for the server-side, but am not super familiar with the Cloudflare adapters, so feel free to correct me |
correct, this is purely about making it possible for server-side logs to have correct stack traces. i've no idea if netlify/cloudflare etc can actually make use of them, but if so then this seems like a good change. will try and check later |
Even if they don't use them yet, I'm not sure it'd be a bad idea to add them as it reduces the number of barriers to getting it working |
Hey, I wrote issue #5337. It was resolved by downgrading to version 65 of netlify's svelte adapter, so something changed and broke between those versions. Just wanted to let you know, and please give me feedback on my conduct as this is my first open source issue. |
You issue is unrelated to this change. The real cause is something else: #5337 (comment) |
Vercel was done here: #5197
We should do the others as well