Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] allow user to set dev port #5303

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[fix] allow user to set dev port #5303

merged 1 commit into from
Jun 29, 2022

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jun 28, 2022

Closes #5296

Array options will be merged. We only need to ensure we're not overriding the remaining primitives which are not in enforced_config
spa option does not exist and can be removed
root already defaults to cwd and can be removed

@benmccann benmccann added the bug Something isn't working label Jun 28, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

🦋 Changeset detected

Latest commit: 84ff8b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit d828ca4 into master Jun 29, 2022
@benmccann benmccann deleted the overridable-opts branch June 29, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kit.vite.server.port in svelte.config.js is not used by svelte-kit dev
2 participants