Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Adjust type imports to satisfy TS NodeNext moduleResolution #5360

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

dummdidumm
Copy link
Member

Discovered through comment in sveltejs/cli#205
This is necessary so people can use this new resolution mode and still get proper typings for things like $app/stores
This isn't all that's needed though:

  • Vite 3 is needed so we get their exports map which makes vite/client resolve correctly
  • Svelte bump needed to properly expose CompileOptions. It's imported from a path which isn't accessible when adhering to export maps

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Discovered through comment in #2040
This is necessary so people can use this new resolution mode and still get proper typings for things like $app/stores
This isn't all that's needed though:
- Vite 3 is needed so we get their exports map which makes vite/client resolve correctly
- Svelte bump needed to properly expose CompileOptions. It's imported from a path which isn't accessible when adhering to export maps
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2022

🦋 Changeset detected

Latest commit: 16c71b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -1,7 +1,7 @@
/// <reference types="svelte" />
/// <reference types="vite/client" />

import './ambient';
import './ambient.js';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks stupid but it's what TS wants when using the new resolution algorithm. Luckily this also works for the old one.

@Rich-Harris
Copy link
Member

Should this be marked draft pending Vite/Svelte updates, or is there value in merging it before then?

@dummdidumm
Copy link
Member Author

There's value in merging as-is already, it makes most of the types usable again with the new mode

@Rich-Harris Rich-Harris merged commit 7e697e8 into master Jul 5, 2022
@Rich-Harris Rich-Harris deleted the ts-nodenext-types branch July 5, 2022 20:39
This was referenced Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants