Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update vite ssr repro template #5713

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 26, 2022

Recommend a simpler version of Vite SSR template for checking if it's a Vite bug.

Uses https://github.com/bluwy/create-vite-extra

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

⚠️ No Changeset found

Latest commit: ca73f7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title update vite ssr repro template [docs] update vite ssr repro template Jul 26, 2022
@benmccann benmccann added the documentation Improvements or additions to documentation label Jul 26, 2022
@benmccann benmccann merged commit a6b0f00 into master Jul 26, 2022
@benmccann benmccann deleted the docs-vite-ssr-template branch July 26, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants