Postinstall sync #5760
Postinstall sync #5760
Conversation
🦋 Changeset detectedLatest commit: 072fe86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ahhh. i see |
|
Ok, I think this is slightly simpler than #5651 — I prefer the idea of adding as little code as possible to deal with the case of our own CI stuff — but I'll wait for a 👍 before merging |
| @@ -6,8 +6,7 @@ | |||
| "dev": "vite dev", | |||
| "build": "vite build", | |||
| "preview": "vite preview", | |||
| "prepare": "node ../../cli.js sync", | |||
| "check": "tsc && svelte-check", | |||
| "check": "svelte-kit sync && tsc && svelte-check", | |||
There was a problem hiding this comment.
| "check": "svelte-kit sync && tsc && svelte-check", | |
| "check": "node ../../cli.js sync && tsc && svelte-check", |
without this is always goes to dist for me.
And do we want to keep the prepare script too to work around the fact that pnpm doesn't call postinstall for workspace dependencies in a monorepo?
There was a problem hiding this comment.
Ah yeah, changed it to ../../cli.js so we can test out changes to the sync script without rebuilding.
IIRC the prepare script was running before stuff was built, which meant it didn't work (though that would have been fixed by the ../../cli.js I guess) but in any case "prepare": "svelte-kit sync" is now a no-op, so there's no reason to keep it
There was a problem hiding this comment.
I was thinking of prepare with the ../../cli.js call too, so that when you pull changes and do pnpm i it syncs to avoid red squiggles.
satisfying my curiosity about #5651 (comment)