Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start to remove app utils #600

Merged
merged 9 commits into from
Mar 24, 2021
Merged

start to remove app utils #600

merged 9 commits into from
Mar 24, 2021

Conversation

antony
Copy link
Member

@antony antony commented Mar 23, 2021

Relates to #592

@antony antony marked this pull request as ready for review March 23, 2021 23:42
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. this feels much nicer to me. mind running pnpx changeset before we merge?

@antony
Copy link
Member Author

antony commented Mar 23, 2021

Wasn't sure what our versioning strategy was so I went with patch as per other changsets.

@Rich-Harris Rich-Harris merged commit 8024178 into master Mar 24, 2021
@Rich-Harris Rich-Harris deleted the feature/remove-app-utils branch March 24, 2021 00:04
@Rich-Harris
Copy link
Member

yeah, i've been doing patch. will have to figure out how to break that muscle memory when we leave prerelease mode

@@ -22,7 +21,7 @@ module.exports = function () {
builder.copy_server_files(server_directory);
renameSync(join(server_directory, 'app.js'), join(server_directory, 'app.mjs'));

copy(join(__dirname, 'files'), lambda_directory);
builder.copy(join(__dirname, 'files'), lambda_directory);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any method called copy on the Builder

We really need to introduce type checking everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants