-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] make errors in Action less restrictive #6022
Conversation
🦋 Changeset detectedLatest commit: 6e0e157 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think we added some type tests somewhere? Should we try to cover this with them? |
@Rich-Harris removed them 😄 they were related to the |
Can the type really be Ah, that's why I didn't know where they were anymore 😄 All types are conceptually simple, but we're always making small mistakes where we get things wrong. A test would prevent a regression and clarify how non JSON serializable objects should be treated |
It has to be, yes, but it's impossible to type "this expects a JSON type", see #5974 for more info |
For others, following that link, I found the explanation here: #5963 (comment) I wonder if we should at least do something like:
It doesn't change what's allowed but may help to document what's expected to clarify things for users |
Part of #6015
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0