Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] correct parent data type for layouts #6025

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

dummdidumm
Copy link
Member

Was wrong if a layout referenced a named layout in the same folder
Fixes #6013

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Was wrong if a layout referenced a named layout in the same folder
Fixes #6013
@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022

🦋 Changeset detected

Latest commit: db08670

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

I believe there was an older issue related to sorting of routes somewhere. Probably not related to this, but thought I'd mention it in case you want to check if it closes that issue or you want to address both while working on the same section of code. I hear my kids waking up, so I don't have a chance to look for it at the moment

@dummdidumm
Copy link
Member Author

Do you have an issue number? Can't find it.

@benmccann
Copy link
Member

I can't find it either, so nevermind then 😄

@Rich-Harris Rich-Harris merged commit a5f0506 into master Aug 18, 2022
@Rich-Harris Rich-Harris deleted the fix-layout-parent-type branch August 18, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load parent function doesn't infer LayoutData from named layout
3 participants