Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Suggest props destructuring if possible #6069

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

dummdidumm
Copy link
Member

Should make migration easier in most cases. I've seen enough people do exactly this by hand (or suggest doing this), so I think it's worth suggesting automatically.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Should make migration easier in most cases
@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2022

🦋 Changeset detected

Latest commit: e9e5dde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit b1dafb8 into master Aug 19, 2022
@Rich-Harris Rich-Harris deleted the migration-props-conversion branch August 19, 2022 11:33
Rich-Harris added a commit that referenced this pull request Aug 19, 2022
Rich-Harris added a commit that referenced this pull request Aug 20, 2022
* Revert "[feat] Suggest props destructuring if possible (#6069)"

This reverts commit b1dafb8.

* fix changesets

* Update .changeset/ninety-snakes-melt.md

* Update .changeset/ninety-snakes-melt.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants