-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move hooks.{js|ts}
init to Server.init
instead of Server.respond
#6179
Conversation
🦋 Changeset detectedLatest commit: 5b9b0db The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels way better. comments inline
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Moved the |
Required since sveltejs/kit#6179, as hooks.js are initialized in server.init()
Required since sveltejs/kit#6179, as hooks.js are initialized in server.init()
Required since sveltejs#6179. Closes sveltejs#6308.
As of `1.0.0-next.433` (sveltejs/kit#6179) the build script bundles the app incorrectly. Specifics about the problem: sveltejs/kit#6325
* Run server.init() for edge functions on Vercel. Required since #6179. Closes #6308. * changeset * changes * remove async keyword * Update .changeset/strong-kangaroos-work.md * netlify edge functions * changeset Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Closes #6147.
hooks.js
module toServer.init
instead ofServer.respond
.await
edServer.init
in all adapters that use it (adapter-static
doesn't).TODO:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0