-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorganise codebase a bit #6297
Conversation
|
This seems pretty good overall. The contributing guide would need to be updated. It feels a little weird to me that (the directory tree in the description gave me a chuckle. I think someone's been typing |
I agree with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures seem unrelated/due to flakyness. Will do one rerun to be sure.
Edit: All test failures except one (which looks like flakyness) are related to the $env thing - not sure why it fails this consistently now, it didn't do that before I believe.
The |
The distinction between |
This started out with me working on #4051 and immediately wanting to move
packages/kit/src/hooks.js
topackages/kit/src/hooks/sequence.js
so that we could have asequence.spec.js
alongside it, but not wanting to do that because it would makesrc
even more raggedy than it currently is.As of this PR, the contents of
src
look like this......which I think makes more sense than
src/vite
,src/node
etc. There's definitely more that could be done here (theruntime
directory in particular has become a bit chaotic), but sorting out the top level feels like a good start, and would make me feel calmer when I'm working in the codebase.No changeset because this change should be invisible to users. I used
git mv
to preserve history and minimise the chance of merge conflicts.