-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adapter-vercel] don't use top level await in Vercel Edge Functions #6360
[adapter-vercel] don't use top level await in Vercel Edge Functions #6360
Conversation
🦋 Changeset detectedLatest commit: 5955b60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The problem still exists with // vite.config.ts
import { defineConfig } from 'vitest/config'
import { sveltekit } from '@sveltejs/kit/vite'
export default defineConfig({
build: { target: 'esnext' },
plugins: [sveltekit()],
test: {
include: ['tests/vitest/**/*.{test,spec}.{js,ts}']
}
}) // svelte.config.js
/** @type {import('@sveltejs/kit').Config} */
import adapter from '@sveltejs/adapter-vercel'
import { vitePreprocess } from '@sveltejs/vite-plugin-svelte'
const config = {
kit: {
adapter: adapter( { runtime: 'edge' } ), // <---- edge functions
alias: {
$components: 'src/components',
},
},
preprocess: vitePreprocess(),
vitePlugin: {inspector: true}
}
export default config The top-level await is part of my firebase Initialization // src/lib/firebase/client-init.ts
import { getAuth, type Auth } from 'firebase/auth'
import { deleteApp, getApp, getApps, initializeApp, type FirebaseApp, type FirebaseOptions } from 'firebase/app'
import { getFirestore, type Firestore } from 'firebase/firestore'
import {
PUBLIC_FIREBASE_APIKEY,
PUBLIC_FIREBASE_APPID,
PUBLIC_FIREBASE_AUTHDOMAIN,
PUBLIC_FIREBASE_MEASUREMENTID,
PUBLIC_FIREBASE_MESSAGINGSENDERID,
PUBLIC_FIREBASE_PROJECTID,
PUBLIC_FIREBASE_STORAGEBUCKET
} from '$env/static/public'
const firebaseConfig: FirebaseOptions = {
apiKey: PUBLIC_FIREBASE_APIKEY,
appId: PUBLIC_FIREBASE_APPID,
authDomain: PUBLIC_FIREBASE_AUTHDOMAIN,
measurementId: PUBLIC_FIREBASE_MEASUREMENTID,
messagingSenderId: PUBLIC_FIREBASE_MESSAGINGSENDERID,
projectId: PUBLIC_FIREBASE_PROJECTID,
storageBucket: PUBLIC_FIREBASE_STORAGEBUCKET
}
// REVIEW Switch back to using top-level await; depends on adapter-vercel's edge runtime support
// Make sure we have only one firebaseApp instance
// This is the correct version as it's using `await deleteApp()` which returns a promise
// - However Vercel's edge runtime does not support top-level await as of now (June 2024)
// - see https://github.com/sveltejs/kit/issues/7300
// const firebaseApp: FirebaseApp = (getApps().length === 0 ) ? initializeApp(firebaseConfig) : (await deleteApp(getApp()), initializeApp(firebaseConfig))
// Use `deleteApp()` without await for now
const firebaseApp: FirebaseApp = (getApps().length === 0 ) ? initializeApp(firebaseConfig) : (deleteApp(getApp()), initializeApp(firebaseConfig))
export const firebaseAuth: Auth = getAuth(firebaseApp)
export const firebaseFirestore: Firestore = getFirestore(firebaseApp) |
This fixes a regression created in #6327, due to the usage of top level await, which isn't supported in Vercel Edge Functions right now.
Using a deferred promise and awaiting within the response it practically the same thing, but works.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0