Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by compressing in parallel #6710

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

sanjaiyan-dev
Copy link
Contributor

@sanjaiyan-dev sanjaiyan-dev commented Sep 9, 2022

Improving the performance by running the independent async functions in parallel ✈️.

Sorry if I made any mistakes :(

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

🦋 Changeset detected

Latest commit: aad5636

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

You need to run pnpm format to get the Lint CI check to pass. Right now it's failing with:

@sveltejs/adapter-static:lint: [warn] Code style issues found in the above file. Forgot to run Prettier?

@sanjaiyan-dev
Copy link
Contributor Author

You need to run pnpm format to get the Lint CI check to pass. Right now it's failing with:

@sveltejs/adapter-static:lint: [warn] Code style issues found in the above file. Forgot to run Prettier?

Extremely sorry, I used GitHub web based editor so I couldn't run lint command, Can you please help me with it :)

@benmccann
Copy link
Member

You can address it by checking out the code on your machine:

git clone git@github.com:sanjaiyan-dev/svelte-kit.git
cd svelte-kit
git checkout sanjaiyan-static-parallel
pnpm install
pnpm format

@sanjaiyan-dev
Copy link
Contributor Author

You can address it by checking out the code on your machine:

git clone git@github.com:sanjaiyan-dev/svelte-kit.git
cd svelte-kit
git checkout sanjaiyan-static-parallel
pnpm install
pnpm format

Tks a lot

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the formatting change for you

packages/adapter-node/index.js Outdated Show resolved Hide resolved
@sanjaiyan-dev
Copy link
Contributor Author

I pushed the formatting change for you

Tks 💪🙌

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@benmccann benmccann changed the title Improve performance by running functions in parallel ✈️ Improve performance by compressing in parallel Sep 10, 2022
@dummdidumm dummdidumm merged commit ec88a70 into sveltejs:master Sep 12, 2022
@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-static-parallel branch September 13, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants