Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit Status Update According to Svelte Summit RC1 Announcement #6719

Closed
wants to merge 2 commits into from
Closed

SvelteKit Status Update According to Svelte Summit RC1 Announcement #6719

wants to merge 2 commits into from

Conversation

kvetoslavnovak
Copy link
Contributor

SvelteKit Status Update According to Svelte Summit RC1 Announcement

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

SvelteKit Status Update According to Svelte Summit RC1 Announcement
@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022

⚠️ No Changeset found

Latest commit: be076f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kvetoslavnovak
Copy link
Contributor Author

kvetoslavnovak commented Sep 10, 2022

Sorry. I have just realized there a similar PR already. #6707
But maybe this one is more detail and in compliance what Rich Harris has announced.

@benmccann
Copy link
Member

Thanks. Yeah, I'll close this in favor of #6707, but I've included some of your changes there

@benmccann benmccann closed this Sep 10, 2022
@kvetoslavnovak
Copy link
Contributor Author

Great. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants