Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use justify-content: flex-start; on Sverdle CSS to avoid compatibility issues #7352

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

Tal500
Copy link
Contributor

@Tal500 Tal500 commented Oct 22, 2022

This also eliminates the Vite warnings:
[vite:css] start value has mixed support, consider using flex-start instead

Using justify-content: flex-start; has here the same result as justify-content: start; (they are different only if the flex direction is opposite to the natural), and it has a wider compatibility (see caniuseit).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

…ity issues

This also eliminates the Vite warnings:
[vite:css] start value has mixed support, consider using flex-start instead
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2022

🦋 Changeset detected

Latest commit: de92f1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants