Upgrade to Vite 4

[benmccann]

Shouldn't affect SvelteKit or its users much other than bumping a version. One nice change is that it fixes the value of NODE_ENV to be more inline with what one would expect, which I think should help us clean some stuff up

To migrate, simply bump your Vite and SvelteKit versions to the latest versions. See the full Vite 4 migration guide and announcement for more details

[changeset-bot]

🦋 Changeset detected

Latest commit: 8c12306

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@sveltejs/kit	Patch
@sveltejs/adapter-cloudflare	Patch
@sveltejs/adapter-cloudflare-workers	Patch
@sveltejs/adapter-netlify	Patch
@sveltejs/adapter-vercel	Patch
@sveltejs/adapter-node	Patch
create-svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

i think this broke paths.assets handling. investigating

[Bandit]

I'm probably stupid, but I went into package.json and set

"@sveltejs/kit": "^1.0.0-next.582"
"vite": "^4.0.0"

And then npm i and get Conflicting peer dependency: vite@4.0.0. No idea why?

[benmccann]

I haven't seen that. Can you share a project that reproduces the issue?

[Bandit]

Just tried to recreate the issue in StackBlitz but it seems to work fine, so guessing it's something specific to this (private) repo.

I tried renaming node_modules before running npm i but it gives me basically the same error:

npm ERR! Found: vite@3.2.5
npm ERR! node_modules/vite
npm ERR!   dev vite@"^3.0.4" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^4.0.0" from @sveltejs/kit@1.0.0-next.582
npm ERR! node_modules/@sveltejs/kit
npm ERR!   dev @sveltejs/kit@"^1.0.0-next.582" from the root project

I don't really know where to even start debugging the issue since I don't know a lot about NPM's inner workings. I could use --force or --legacy-peer-deps but that sounds scary

[benmccann]

npm ERR! Found: vite@3.2.5
npm ERR! node_modules/vite
npm ERR! dev vite@"^3.0.4" from the root project

That sounds like you still have Vite 3 in a package.json somewhere.

Another thing you could try is rm -rf package-lock.json node_modules && npm install

[Bandit]

That fixed it. Really appreciate the help - realise you're not tech support! Not sure what was wrong with my setup 😅