Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create-svelte] Fix playwright filter #7826

Merged
merged 2 commits into from
Nov 27, 2022

Conversation

gtm-nayan
Copy link
Contributor

closes #7825

The globs weren't matching, playwright has a default testMatch that works pretty well as long as we contain it with testDir and it's nice to have fewer moving parts so did away with globs altogether

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2022

🦋 Changeset detected

Latest commit: d3a836e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gtm-nayan gtm-nayan changed the title Fix playwright filter [create-svelte] Fix playwright filter Nov 27, 2022
@Rich-Harris Rich-Harris merged commit 995dbcf into sveltejs:master Nov 27, 2022
@gtm-nayan gtm-nayan mentioned this pull request Apr 28, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright testing does not work out of the box.
2 participants