feat: Typing improvements to preload PR #7841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 tasks
gtm-nayan
reviewed
Nov 28, 2022
dummdidumm
reviewed
Nov 28, 2022
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
dummdidumm
reviewed
Nov 28, 2022
Rich-Harris
added a commit
that referenced
this pull request
Nov 28, 2022
…)` (#7776) * rename prefetch -> preload and prefetchRoutes -> prepare, tweak prepare API * rename data-sveltekit-prefetch to data-sveltekit-preload * update migration guide * various * shuffle some things around * refactor a tiny bit * fix * implement data-sveltekit-prepare * make it slightly more self-contained * keyboard events * named constants * handle malformed URLs * rename * use data-sveltekit-preload-code and data-sveltekit-preload-data * rename stuff * fix * docs * missed a spot * changesets * clarification * fix migration guide * tidy up * feat: Typing improvements to preload PR (#7841) * feat: Improve typings on data-sveltekit attributes * feat: improved constants * Update packages/kit/src/runtime/client/utils.js Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> * remove dev guard from validateAttributeValue * snake_case * dot notation * shorter name so prettier doesnt butcher the code * shorter name * get typechecking working * neaten * oops * tweak Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-advanced/30-link-options.md * move up explanation of mobile behaviour * clarify * Update packages/kit/src/runtime/client/client.js Co-authored-by: S. Elliott Johnson <sejohnson@torchcloudconsulting.com> * change "page" to "eager" * make side-effecty * oops * fix docs Co-authored-by: S. Elliott Johnson <sejohnson@torchcloudconsulting.com> Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider these changes as 100% a suggestion -- I figured this was easier than making some super-complex GitHub comment. This should be safe to merge into the branch without additional changes.
This more explicitly states what typings we're going for in this utils file. As with most situations where we provide stricter types, this just helps us not shoot ourselves in the foot later by somehow introducing
undefinedwhere we expect null, adding a new value todata-sveltekit-blahwithout updating it everywhere it occurs, etc. The main improvement is just in the parsing and validation when we pulldata-sveltekit-{x}values from DOM elements. Some mapped typing there ensures that we're both validating the value and that the data attribute we're trying to retrieve provides the values we want it to.