-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate TS with satisfies
#8001
Conversation
|
It looks like |
I can't see the deploy error messages, but to my knowledge there shouldn't be any issues with twoslash accepting satisfies as a keyword - twoslash doesn't put a constraint on TS I think, so it should just accept whatever version is in the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had nothing to do with Shiki, just some syntax error and then new errors popping up that needed silencing
would be nice to get this change in as it reduces the need for proxy types. the site won't build though, because (I think) shiki-twoslash is using an older TypeScript and doesn't know how to deal with the newfangled syntax. A cursory glance didn't show me how to fix it so I'm just going to leave this here for a moment