-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] add builder.generateFallback(fallback)
API
#8013
Conversation
🦋 Changeset detectedLatest commit: ccb7853 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
builder.generateFallback(fallback)
API
Did something change in recent releases around this behavior? Specifically, is this claim still true: "no rendering takes place during the build unless When upgrading from 1.0.0 to 1.2.10 our build fails with "Prerendering failed with code 1", and an error saying |
What error message specifically? Is this #8536 by any chance? |
No, it doesn't seem like that error. Here's what I am getting:
|
Following up on my question about whether this behavior has changed. For our build, we start seeing the error above when we move from https://github.com/sveltejs/kit/releases/tag/%40sveltejs%2Fkit%401.0.13 I'll check out what changes were included in this release. |
Might be #8655 then |
Yes, I just found that issue as well. It does seem to be the same. Things provided by node are no longer available during the pre-render? I still question why it is even pre-rendering at all though. Any ideas on that @dummdidumm ? |
It's not really prerendering, it's loading the code to analyse it |
closes #7899. This changes the behaviour around fallback
200.html
/404.html
pages so that they are only generated when needed (which, in practice, means only inadapter-static
).As a result, no rendering takes place during the build unless
prerender.entries
is populated.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0