Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] prerender shells when ssr false and prerender not false #8131

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Dec 13, 2022

Closes #3966

This is a breaking change insofar that pages that have export const ssr = false and not explicitly set export const prerender = false or prerender.entries: [] will have their handle hooks run, which could be unexpected and cause unintended side effects. In that's the case for you, add export const prerender = false next to wherever you have export const ssr = false.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

🦋 Changeset detected

Latest commit: 513fd1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

get_option(nodes, 'ssr') === false &&
!leaf_node.server?.actions
) {
return await render_response({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated to code a little further below, but this way it's more readable (you don't need to hold all these conditions in your head until you arrive at the other condition)

packages/kit/src/runtime/server/page/index.js Show resolved Hide resolved
@dummdidumm
Copy link
Member Author

Ha, this uncovered an unrelated bug in write_types. I removed the check for now to get CI green. When I open the PR to fix it I'll reenable it.

Rich-Harris added a commit that referenced this pull request Mar 7, 2023
dummdidumm pushed a commit that referenced this pull request Mar 8, 2023
reverts #8131
This reverts the optimisation wherein pages with ssr = false and no explicit prerender = false would automatically be prerendered, as it turns out to be unsafe.

fixes #9275
fixes #8428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-SSR'd pages should be prerendered by default
2 participants