-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Add prerendered assets to Vercel config #8332
[Fix] Add prerendered assets to Vercel config #8332
Conversation
🦋 Changeset detectedLatest commit: 048dcfe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you. (This does result in some duplication, but it's at least explicit. Probably not worth creating a new package that they both depend on in order to reduce that duplication.) |
Thanks a lot, I wasn't sure, because I was surprised by the totally different code between these two. Good idea to unify them 😊 |
Hello!
Solves #8331
Before prerendered data.json or other non-html pages weren't included in Vercel config. It correctly adds them to it.
I monkey patched the change to my private project and it correctly worked. While fixing I found that it's also applicable to adapter Vercel. However, I'm not familiar with the codebase and the adapters system, so I'm not sure about the correctness of my approach. I'm also not sure about the test for the change but can provide one if given some advice and it's needed 😀
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0