Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] prerendered endpoint callable from non-prerendered server load #8453

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

dummdidumm
Copy link
Member

Fixes #8341

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2023

🦋 Changeset detected

Latest commit: ee50d55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

not even going to try and understand why this works/how it was broken before, but i'm glad the fix is so simple

@Rich-Harris Rich-Harris merged commit 9c01c32 into master Jan 11, 2023
@Rich-Harris Rich-Harris deleted the prerender-endpoint branch January 11, 2023 16:29
@github-actions github-actions bot mentioned this pull request Jan 11, 2023
@dummdidumm
Copy link
Member Author

dummdidumm commented Jan 11, 2023

Good point; this needs a little explanation:
state.initiator wasn't set previously when responding to a __data.json call. If that __data.json call then leads to another internal call (as happened in the bug report), respond runs again (through the internal fetch). It then searches for a manifest entry of that server endpoint, doesn't find one (because it was prerendered), and throws an error if state.initiator isn't set. state.initiator being set doesn't throw the error and instead proceeds to do a native fetch, which is then able to load the prerendered server endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerendered endpoint cannot be fetched by provided fetch in server load
2 participants