Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input name overriding form method and action checks #8471

Merged
merged 7 commits into from
Jan 13, 2023
Merged

fix: input name overriding form method and action checks #8471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d55f4f
change form.method to form.getAttribute
eltigerchino Jan 11, 2023
3dbc443
add changeset
eltigerchino Jan 11, 2023
0bf7b54
normalise form.getAttribute value
eltigerchino Jan 11, 2023
a5dcfe5
remove helper method and use HTMLFormElement.prototype
eltigerchino Jan 11, 2023
ac185a3
change form.action to use HTMLFormElement.prototype
eltigerchino Jan 11, 2023
10fc355
revert unneccesary form cloning from runtime/client.js
eltigerchino Jan 12, 2023
b665068
tidy up
dummdidumm Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-plants-relate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: avoid input name clobbering form method check
6 changes: 5 additions & 1 deletion packages/kit/src/runtime/app/forms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ export function deserialize(result) {

/** @type {import('$app/forms').enhance} */
export function enhance(form, submit = () => {}) {
if (DEV && form.method !== 'post') {
if (
DEV &&
/** @type {HTMLFormElement} */ (HTMLFormElement.prototype.cloneNode.call(form)).method !==
'post'
) {
throw new Error('use:enhance can only be used on <form> fields with method="POST"');
}

Expand Down