docs: more build docs #8500
Closed
docs: more build docs #8500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b588918 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
added a commit
that referenced
this pull request
Jan 13, 2023
Transforming the adapters document into a more general build doc closes #8500
dummdidumm
force-pushed
the
build-docs
branch
from
84cb5eb to
ccf95db
Compare
dummdidumm
added a commit
that referenced
this pull request
Jan 13, 2023
dummdidumm
added a commit
that referenced
this pull request
Jan 13, 2023
5 tasks
Transforming the adapters document into a more general build doc closes #8500
dummdidumm
force-pushed
the
build-docs
branch
from
ccf95db to
dc787f7
Compare
dummdidumm
added a commit
that referenced
this pull request
Jan 13, 2023
|
I really hate that we have to bump the adapter packages everytime we update their docs. Maybe we should take this opportunity to move their docs from the READMEs to the docs folder? That gives me another idea which would be to create a Building Your App section. Within that could live the new page, the general adapters docs, and docs for each individual official adapter. |
|
closing in favour of #8531 |
Rich-Harris
added a commit
that referenced
this pull request
Jan 18, 2023
* docs: more build docs Transforming the adapters document into a more general build doc closes #8500 * fix * docs: move adapter docs to site * update page titles * ignore typescript errors * revert url change * some more reversions * reorder sidebar * tweaks * rename to build and deploy * fix casing * tweaks * separate out writing section * tweaks * formatting * tweaks * expose App.Platform automatically if adapter-cloudflare-workers is installed * Update .changeset/hungry-singers-tease.md * Update .changeset/hungry-singers-tease.md * fix links * amend App.Platform * fix, hopefully * tweaks Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transforming the adapters document into a more general build doc
Closes #8436
The alternative to this is to introduce another top level document (keeping the adapter doc as is) - I'm fine with that, too.
Maybe I actually prefer that; opened #8501 for comparison
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.