Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude service worker from tsconfig #8508

Merged
merged 2 commits into from
Jan 13, 2023
Merged

fix: exclude service worker from tsconfig #8508

merged 2 commits into from
Jan 13, 2023

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jan 13, 2023

This is necessary so the recommended way to get sw types doesn't remove the globals from other files in the project.
Also document how to get types working inside the file closes #8127

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Also document how to get types working inside the file
closes #8127
@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023

🦋 Changeset detected

Latest commit: 4d8a7df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

/// <reference lib="esnext" />
/// <reference lib="webworker" />

const ws = /** @type {ServiceWorkerGlobalScope} */ (/** @type {unknown} */ (self));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ws (and not, say, sw)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant sw 😂

@Rich-Harris Rich-Harris merged commit 6c7f9b2 into master Jan 13, 2023
@Rich-Harris Rich-Harris deleted the sw-types branch January 13, 2023 19:09
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate types for src/service-worker.js
2 participants