fix: provide proper error when POSTing to a missing page endpoint #8714
Conversation
🦋 Changeset detectedLatest commit: 9000f87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -69,23 +69,23 @@ export async function handle_action_json_request(event, options, server) { | |||
| }); | |||
| } | |||
| } catch (e) { | |||
| const error = normalize_error(e); | |||
| const err = normalize_error(e); | |||
There was a problem hiding this comment.
FYI @bluwy , I think there's a Vite bug where it thinks that error is the function imported at the top, not the const declared here.
There was a problem hiding this comment.
👍 looks like @gtm-nayan got it fixed at vitejs/vite#11811
| return leaf_node.server && event.request.method !== 'GET' && event.request.method !== 'HEAD'; | ||
| export function is_action_request(event) { | ||
| const { method } = event.request; | ||
| return method !== 'GET' && method !== 'HEAD'; |
There was a problem hiding this comment.
On my phone so viewing the code a few lines at a time and could be misunderstanding, but shouldn't this be checking that method is POST?
There was a problem hiding this comment.
Was confused by that as well, but didn't want to trigger any unwanted changes so I just kept it as is.
PUT, PATCH, DELETE don't ever reach this point but other unknown methods might, do you want to tighten it down?
There was a problem hiding this comment.
This is probably a reminiscent of old times, yes we can simplify that to just check for POST
Closes #8696
Closes #8713
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.