Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly purge server load cache #8893

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

coyotte508
Copy link
Contributor

@coyotte508 coyotte508 commented Feb 5, 2023

fixes #8272

When going from a page with server load to a page without server load, the cache wasn't purged properly

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

You can check out a repo with the bug here: https://github.com/coyotte508/sveltekit-load-bug/

fixes sveltejs#8272

When going from a page with server load to a page without server load, the cache wasn't purged properly
@Rich-Harris
Copy link
Member

Thank you! Any chance you could add a test for this? It could go in this section:

test.describe('Load', () => {

There already was a test called 'server data from previous is not reused if next page has no load function' but it didn't test the case where the parent's load function is rerun.
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client side navigation incorrectly re-uses data from previous request
3 participants