Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dedent #9273

Merged
merged 9 commits into from
Mar 2, 2023
Merged

chore: dedent #9273

merged 9 commits into from
Mar 2, 2023

Conversation

Rich-Harris
Copy link
Member

Per #9270 (comment), this adds a dedent utility for the places where we need to generate code from template literals. It allows our code to be much more readable, and makes the generated code more reliably readable as well.

Need to use it for the virtual modules declared inline, and figure out whether to use it in render.js (I think the answer is probably 'yes', but want to make sure we can do so without introducing any performance overhead)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@Rich-Harris
Copy link
Member Author

I think the render.js stuff should probably happen as part of a separate refactor, if at all

@Rich-Harris Rich-Harris marked this pull request as ready for review March 2, 2023 03:47
@benmccann benmccann changed the title Dedent chore: dedent Mar 2, 2023
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@Rich-Harris Rich-Harris merged commit 3124296 into master Mar 2, 2023
@Rich-Harris Rich-Harris deleted the dedent branch March 2, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants