Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect when previewing prerendered pages #9353

Merged
merged 2 commits into from
Mar 8, 2023
Merged

redirect when previewing prerendered pages #9353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c2d9d6
redirect when previewing prerendered pages - closes #8839
Rich-Harris Mar 7, 2023
3cff8d6
Update packages/kit/src/exports/vite/preview/index.js
Rich-Harris Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-panthers-leave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: redirect to path with/without trailing slash when previewing prerendered pages
27 changes: 25 additions & 2 deletions packages/kit/src/exports/vite/preview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,31 @@ export async function preview(vite, vite_config, svelte_config) {
let prerendered = is_file(filename);

if (!prerendered) {
filename += filename.endsWith('/') ? 'index.html' : '.html';
prerendered = is_file(filename);
const has_trailing_slash = pathname.endsWith('/');
const html_filename = `${filename}${has_trailing_slash ? 'index.html' : '.html'}`;

let redirect;

if (is_file(html_filename)) {
filename = html_filename;
prerendered = true;
} else if (has_trailing_slash) {
if (is_file(filename.slice(0, -1) + '.html')) {
redirect = pathname.slice(0, -1);
}
} else if (is_file(filename + '/index.html')) {
redirect = pathname + '/';
}

if (redirect) {
res.writeHead(307, {
location: redirect
});

res.end();

return;
}
}

if (prerendered) {
Expand Down