Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin undici to 5.20.0 #9591

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix: pin undici to 5.20.0 #9591

merged 1 commit into from
Apr 4, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 3, 2023

fix #9512

pin undici to 5.20.0 and in renovate. it seems like undici reverted the fix to a memory leak a while ago:

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: 8f825e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry Conduitry merged commit 0e4b9b1 into master Apr 4, 2023
@Conduitry Conduitry deleted the pin-undici-5.20.0 branch April 4, 2023 14:02
@github-actions github-actions bot mentioned this pull request Apr 4, 2023
@eltigerchino eltigerchino mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sveltejs/adapter-node@1.2.3 make memory leak
3 participants