feat: support AWS via SST in adapter-auto #9874

fwang · 2023-05-09T02:28:53Z

This PR adds a check for AWS via SST to adapter-auto. If it succeeds, it uses svelte-kit-sst, which we maintain. This package is not automatically added as a dependency of adapter-auto, users need to install it first.

The check uses the SST environment variable to check if we are building using SST.

I tested this using patch-package on one of my SWA projects and it seemed to work.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

changeset-bot · 2023-05-09T02:28:56Z

🦋 Changeset detected

Latest commit: 0b71427

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/adapter-auto	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

benmccann · 2023-05-09T15:11:48Z

documentation/docs/25-build-and-deploy/95-adapter-aws-sst.md

@@ -0,0 +1,60 @@
+---
+title: AWS via SST


I don't think we'd want to add any docs here. We've only added docs for adapters we maintain. We could potentially link to external docs though

For comparison, the adapter-auto docs link out to the svelte-adapter-azure-swa docs rather than including them on kit.svelte.dev — I think that's the right approach

Ah makes sense! Removed.

Rich-Harris · 2023-05-09T15:28:13Z

Thank you! Can you clarify whether this enables true zero-config support? I'm getting conflicting messages from https://docs.sst.dev/start/svelte and https://docs.sst.dev/constructs/SvelteKitSite.

The goal of adapter-auto is to enable people to deploy their SvelteKit apps to different platforms without any setup, but if setup is required (e.g. prefixing vite dev with sst bind) then it's probably better just to include the adapter setup at the same time, rather than adding a new platform to adapter-auto that doesn't actually enable zero-config. We definitely do want to support platforms that are truly zero-config though.

fwang · 2023-05-09T19:41:30Z

@benmccann @Rich-Harris Appreciate the quick review!

I should clarify that sst bind is an optional step. It's only when you want to interact with other AWS services.

Our goal is to deploy your Svelte app to AWS with zero config. Here's how it works:

cd my-svelte-app
npm create sst
npx sst deploy

The 2nd command npm create sst currently blindly overwrites the svelte.config.js file with a minimal config using the svelte-kit-sst adapter. Given that most users are already using the auto adapter, it'd be much cleaner/safer if SST didn't have to touch the config.

Let me know if that aligns with auto adapter's vision.

.changeset/rotten-ducks-tan.md

Rich-Harris · 2023-05-17T14:46:47Z

makes sense — thank you!

* feat: Add a speedier script tag for prerendered redirects (sveltejs#9911) * feat: Add a script redirect to prerendered pages * changeset * Update .changeset/hungry-rocks-hunt.md Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix test * feat: Update string escaping * Update .changeset/hungry-rocks-hunt.md Co-authored-by: Conduitry <git@chor.date> --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Conduitry <git@chor.date> * fix: avoid inlining raw/url CSS imports (sveltejs#9925) * fix: use transformRequest for CSS modules * just avoid raw or url * test and changeset * use parsed query * remove only * Update packages/kit/test/apps/basics/test/cross-platform/test.js * drive by test speed up * feat: prerender & analyse in worker rather than subprocess to support Deno (sveltejs#9919) * feat(fork): use workers * Create hot-actors-hope.md * Update packages/kit/src/utils/fork.js Co-authored-by: Rich Harris <hello@rich-harris.dev> --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <hello@rich-harris.dev> * avoid using isMainThread, since it interacts poorly with vitest (sveltejs#9941) Co-authored-by: Rich Harris <git@rich-harris.dev> * chore: bump vite and devalue (sveltejs#9933) * bump vite and devalue * update templates * merge master * fix test --------- Co-authored-by: Rich Harris <git@rich-harris.dev> * chore: uvu -> vitest for create-svelte tests (sveltejs#9910) * chore: uvu -> vitest for create-svelte tests * format * concurrency (sveltejs#9921) * realised we werent typechecking this file, found some errors. fixed * Wait for beforeAll hook to complete * simplify * exclude create-svelte/template files from prettier, so that we can emit correctly formatted templates * remove unused file * Revert "exclude create-svelte/template files from prettier, so that we can emit correctly formatted templates" This reverts commit aa188d4. --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * feat: unshadow `form` and `data` in `enhance` (sveltejs#9902) * feat: Un-shadow `data` and `form` in `enhance`, warn about future deprecation in dev * changeset * snek * Update .changeset/odd-crews-own.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * Update packages/kit/test/apps/dev-only/package.json Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * am not smart * still not smart * oops * oof * add deprecation notice --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * fix: Set loader: { '.wasm': 'copy' } in esbuild config in `adapter-cloudflare-workers` (sveltejs#9940) * fix: Set loader: { '.wasm': 'copy' } in esbuild config in `adapter-cloudflare-workers` Copies WASM files in Cloudflare instead of trying to load them. Related to sveltejs#9909 * Create brave-peaches-buy.md * Update packages/adapter-cloudflare-workers/index.js * format --------- Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Rich Harris <hello@rich-harris.dev> * fix: Flaky test (sveltejs#9947) * fix: Flaky test * reuse locator * add semi * drive by test speed up * another classic * oh my god brain, y u so bad --------- Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: gtmnayan <gtmnayan@gmail.com> * remove envVarsInUse (sveltejs#9942) Co-authored-by: Rich Harris <git@rich-harris.dev> * fix: type `vitePlugin` in config (sveltejs#9946) * fix: type `vitePlugin` in config * changeset * fix: Set `loader: { '.wasm': 'copy' }` in esbuild config in `adapter-vercel` (sveltejs#9944) * fix: Enable wasm copy in adapter-vercel * Create olive-rings-eat.md --------- Co-authored-by: Rich Harris <richard.a.harris@gmail.com> * feat: crawl URLs in `<meta>` tags (sveltejs#9900) * Crawl social-image urls during prerender * Formatting & Linting * Format changeset & added exhaustive list of crawlable urls * Changed severity to minor as described in sveltejs#5228 * Added support for `property` attribute & limited valid names to just social tags * More tests * Better changeset message - I'm indecisive * Update .changeset/thirty-garlics-tan.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * simplify * simplify * Removed redundant data-sanitation * DRY out --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * Version Packages (sveltejs#9893) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: support AWS via SST in adapter-auto (sveltejs#9874) * [feat] support AWS via SST in adapter-auto * Sync * Delete 95-adapter-aws-sst.md * Update .changeset/rotten-ducks-tan.md --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> * Version Packages (sveltejs#9953) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * only cache response if response has cache-control header (sveltejs#9885) * only cache response if response has cache-control header * add changeset * Version Packages (sveltejs#9955) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: ensure styles are loaded in dev mode for routes containing special characters (sveltejs#9894) * Fix loading styles for routes containing special characters in dev mode. SvelteKit doesn't decode special characters in pathnames when loading CSS modules in dev mode, resulting in an error: Internal server error: Failed to load url /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte=&type=style&lang.css=&inline= (resolved id: /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte&type=style&lang.css). Does the file exist? Actual path: /src/routes/(special)/hinnapäring/ Fix by using decodeURI on the url.pathname when loading CSS modules. * Create stale-houses-yell.md * decodeURL inside if * add test --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * feat: Warn users when submitting forms with files but no `enctype="multipart/form-data"` (sveltejs#9888) * fix: Package name keeps me from filtering with pnpm * feat: Warn users when submitting a form containing a file without the correct enctype * changeset * Update packages/kit/src/runtime/app/forms.js Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> * style * moar style tweaks * better test skip * Update .changeset/tasty-llamas-relate.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * DRY out * only warn once per submit * Update .changeset/tasty-llamas-relate.md Co-authored-by: Rich Harris <richard.a.harris@gmail.com> --------- Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Rich Harris <richard.a.harris@gmail.com> * Version Packages (sveltejs#9957) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * security: Stop automatically adding URLs from server-side `load` `fetch` calls to dependencies (sveltejs#9945) * feat: Add `dangerZone` config * breaking: Don't implicitly track deps in server-side fetch * changeset * bein dumb * fix: Server load invalidation * fix: Write config for server * fix: test * unsurprisingly i am dumb * docs: Clarify difference between server `fetch` and universal `fetch` * tests * rename to trackServerFetches --------- Co-authored-by: Rich Harris <git@rich-harris.dev> * Version Packages (sveltejs#9963) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: S. Elliott Johnson <sejohnson@torchcloudconsulting.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Conduitry <git@chor.date> Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: Fernando López Guevara <fernando.lguevara@gmail.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Conner <conner@semicognitive.com> Co-authored-by: gtmnayan <gtmnayan@gmail.com> Co-authored-by: Loris Sigrist <43482866+LorisSigrist@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Frank <frank@sst.dev> Co-authored-by: Frank Dumont <fj.dumont@gmail.com> Co-authored-by: Reio Remma <reio@mrstuudio.ee>

fwang added 2 commits May 8, 2023 22:08

[feat] support AWS via SST in adapter-auto

8f3f641

Sync

8a54caf

vercel bot deployed to Preview – kit May 9, 2023 02:29 View deployment

benmccann changed the title ~~[feat] support AWS via SST in adapter-auto~~ feat: support AWS via SST in adapter-auto May 9, 2023

benmccann reviewed May 9, 2023

View reviewed changes

Delete 95-adapter-aws-sst.md

981cf02

vercel bot deployed to Preview – kit May 9, 2023 16:10 View deployment

Rich-Harris approved these changes May 17, 2023

View reviewed changes

Rich-Harris reviewed May 17, 2023

View reviewed changes

.changeset/rotten-ducks-tan.md Outdated Show resolved Hide resolved

Update .changeset/rotten-ducks-tan.md

0b71427

Rich-Harris approved these changes May 17, 2023

View reviewed changes

Rich-Harris merged commit 702f49b into sveltejs:master May 17, 2023

vercel bot deployed to Preview – kit May 17, 2023 14:46 View deployment

github-actions bot mentioned this pull request May 17, 2023

Version Packages #9953

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support AWS via SST in adapter-auto #9874

feat: support AWS via SST in adapter-auto #9874

fwang commented May 9, 2023

changeset-bot bot commented May 9, 2023 •

edited

Loading

benmccann May 9, 2023

Rich-Harris May 9, 2023

fwang May 9, 2023

Rich-Harris commented May 9, 2023

fwang commented May 9, 2023 •

edited

Loading

Rich-Harris commented May 17, 2023

feat: support AWS via SST in adapter-auto #9874

feat: support AWS via SST in adapter-auto #9874

Conversation

fwang commented May 9, 2023

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

changeset-bot bot commented May 9, 2023 • edited Loading

🦋 Changeset detected

benmccann May 9, 2023

Choose a reason for hiding this comment

Rich-Harris May 9, 2023

Choose a reason for hiding this comment

fwang May 9, 2023

Choose a reason for hiding this comment

Rich-Harris commented May 9, 2023

fwang commented May 9, 2023 • edited Loading

Rich-Harris commented May 17, 2023

changeset-bot bot commented May 9, 2023 •

edited

Loading

fwang commented May 9, 2023 •

edited

Loading