Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG fillRule attribute is not recognized #1034

Closed
ebeloded opened this issue May 28, 2021 · 1 comment
Closed

SVG fillRule attribute is not recognized #1034

ebeloded opened this issue May 28, 2021 · 1 comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@ebeloded
Copy link

Describe the bug
If svg element has fillRule property, the following error appears:

Property 'fillrule` does not exist on type SVGProps<SVGSVGElement>

Note the lowercasing in the error message. The fillRule does exist on SVGAttrubutes interface, but for some reason the prop gets lowercased. Same doesn't happen for the viewBox attribute - it is recognized as is.

To Reproduce

<svg fillRule="evenodd">
</svg>

Expected behavior
Expected to see no error

Screenshots
image

System (please complete the following information):

  • OS: Mac OS
  • IDE: VSCode
  • Plugin/Package: svelte2tsx, I guess

Workaround
I don't know a workaround, but it would helpful to know if there is a way to use tsignore in Svelte templates

@ebeloded ebeloded added the bug Something isn't working label May 28, 2021
@dummdidumm
Copy link
Member

dummdidumm commented May 28, 2021

The attribute is called fill-rule, we need to change that in the typings.
About ignore-comments, see #1026

dummdidumm added a commit that referenced this issue May 28, 2021
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants