Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align types with Svelte v3.58.0 #1968

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

brunnerh
Copy link
Member

Makes target property match type change from:

@dummdidumm
Copy link
Member

Thanks!

@dummdidumm dummdidumm merged commit 65a23ac into sveltejs:master Mar 31, 2023
@brunnerh brunnerh deleted the patch-shim-target-type branch March 31, 2023 09:15
@brunnerh
Copy link
Member Author

brunnerh commented Mar 31, 2023

Releases of the relevant packages/extensions would be appreciated, as right now the mismatch leads to errors:

import type { ComponentType } from 'svelte';
import Messages from './messages.svelte';

let component: ComponentType;
component = Messages;
Type 'typeof Messages__SvelteComponent_' is not assignable to type 'ComponentType<SvelteComponentTyped<any, any, any>>'.
  Types of parameters 'options' and 'options' are incompatible.
    Type 'ComponentConstructorOptions<any>' is not assignable to type 'Svelte2TsxComponentConstructorParameters<{ messages?: string[] | undefined; clear?: (() => void) | undefined; add?: ((message: string) => void) | undefined; }>'.
      Types of property 'target' are incompatible.
        Type 'Element | ShadowRoot | Document' is not assignable to type 'Element | ShadowRoot'.
          Type 'Document' is not assignable to type 'Element | ShadowRoot'.
            Type 'Document' is missing the following properties from type 'ShadowRoot': delegatesFocus, host, mode, slotAssignment, innerHTMLts(2322)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants