fix: don't duplicate comments of nested script/style tags (#425)

fixes #400
sveltejs · Jan 29, 2024 · cc856a0 · cc856a0
1 parent 1884f22
commit cc856a0
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 3.2.0 (Unreleased)
 
 -   (feat) format JSON script tags
+-   (fix) don't duplicate comments of nested script/style tags
 
 ## 3.1.2
 

diff --git a/src/embed.ts b/src/embed.ts
@@ -366,7 +366,8 @@ async function embedTag(
         // the new position.
         return [...comments, result, hardline];
     } else {
-        return comments.length ? [...comments, result] : result;
+        // Only comments at the top level get the special "move comment" treatment.
+        return isTopLevel && comments.length ? [...comments, result] : result;
     }
 }
 

diff --git a/src/print/index.ts b/src/print/index.ts
@@ -46,7 +46,6 @@ import {
 import {
     ASTNode,
     AttributeNode,
-    CommentInfo,
     CommentNode,
     IfBlockNode,
     Node,

diff --git a/test/printer/samples/script-style-inside-element-comment.html b/test/printer/samples/script-style-inside-element-comment.html
@@ -0,0 +1,10 @@
+<div>
+    <!-- hello -->
+    <style></style>
+</div>
+<svelte:head>
+    <!-- world -->
+    <script>
+        let x;
+    </script>
+</svelte:head>