Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Use window.location.hostname for dev client #165

Closed
Rich-Harris opened this issue Mar 5, 2018 · 0 comments · Fixed by #185
Closed

Use window.location.hostname for dev client #165

Rich-Harris opened this issue Mar 5, 2018 · 0 comments · Fixed by #185

Comments

@Rich-Harris
Copy link
Member

via sveltejs/sapper-template#40 (comment) —

at the moment the host for the dev client is always localhost:${someport} — it should probably be ${window.location.hostname}:${someport} so that debugging on mobile devices etc works
Rich-Harris added a commit that referenced this issue Mar 10, 2018
@Rich-Harris
use window.location.hostname in dev client - fixes #165
61000a4
@Rich-Harris Rich-Harris mentioned this issue Mar 10, 2018
Merged
Rich-Harris added a commit that referenced this issue Mar 10, 2018
@Rich-Harris
Merge pull request #185 from sveltejs/gh-165
fb24c86 
use window.location.hostname in dev client
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use window.location.hostname in dev client sveltejs/sapper
1 participant
@Rich-Harris