Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

v0.13.0 __sapper__ EventStream seems to be borked #276

Closed
arxpoetica opened this issue Jun 1, 2018 · 1 comment · Fixed by #281
Closed

v0.13.0 __sapper__ EventStream seems to be borked #276

arxpoetica opened this issue Jun 1, 2018 · 1 comment · Fixed by #281

Comments

@arxpoetica
Copy link
Member

It's dumping null messages every so many milliseconds.

See screen recordings:

I went back and forth determining if it was my project or could be reproduced in https://github.com/sveltejs/sapper-template <- quick note, it can't be reproduced UNLESS YOU UPDATE sapper-template to sapper@0.13.0. Right now it's on v .12: https://github.com/sveltejs/sapper-template/blob/master/package.json#L17

Once you update the Sapper version, sapper-template EventStream __sapper__ network connection gets borked too.

Rich-Harris added a commit that referenced this issue Jun 5, 2018
reinstate ten second interval between heartbeats
@Rich-Harris
Copy link
Member

Absolute facepalm. I rewrote some stuff for 0.13 to break some CLI functionality out into an API that could be used by other clients (i.e. Sapper Studio), and managed to write the following code:

setInterval(() => {
  this.send(null);
}); // <-- look ma, no second argument!

Surprised TypeScript didn't yell at me. Fixed in 0.13.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants