Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Shell "index.html" file is not created #422

Closed
nolanlawson opened this issue Sep 7, 2018 · 0 comments · Fixed by #525
Closed

Shell "index.html" file is not created #422

nolanlawson opened this issue Sep 7, 2018 · 0 comments · Fixed by #525
Labels

Comments

@nolanlawson
Copy link
Contributor

(Follow-up to #108)

Steps to repro:

git clone https://github.com/sveltejs/sapper-template.git
cd sapper-template
npm install
npm run build
npm start

Then go to localhost:3000/index.html in your browser.

Expected result: there is a shell HTML file, as described in this comment in the sapper-template service-worker.js.

Actual result: there is no shell HTML file, so the page 404s.

This makes it impossible AFAICT to build an actual offline-first Sapper app, i.e. one where the HTML page is cached by the Service Worker. Also this was working as of roughly January 2018, in the fork of Sapper I'm using for Pinafore.

I tested sapper export and it seems to have the same issue.

@Rich-Harris Rich-Harris added the bug label Sep 8, 2018
nolanlawson added a commit to nolanlawson/sapper that referenced this issue Dec 2, 2018
nolanlawson added a commit to nolanlawson/sapper that referenced this issue Dec 2, 2018
nolanlawson added a commit to nolanlawson/sapper that referenced this issue Dec 8, 2018
nolanlawson added a commit to nolanlawson/sapper that referenced this issue Dec 12, 2018
nolanlawson added a commit to nolanlawson/sapper that referenced this issue Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants