-
-
Notifications
You must be signed in to change notification settings - Fork 432
Support better stack trace with sourcemaps #1357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for picking this PR up!
} | ||
); | ||
|
||
file_cache.clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure what the point of the file_cache
is if it's cleared everytime we try to source map an exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that in a stack trace, sometimes you can hit the same file with different lines and cols. The file_cache
there is just a means to avoid rereading that file multiple times in a single call to sourcemap_stacktrace
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me
@habibrosyad this PR will need to be rebased |
@benmccann done... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is brilliant. Makes diagnosing server-errors easy. Thank you!
Co-authored-by: Teoxoy <28601907+Teoxoy@users.noreply.github.com>
This PR is a continuity of #773 by adding test and fix found issues.
Closes #117
Closes #773
Before submitting the PR, please make sure you do the following
npm run lint
!)Tests
npm test
oryarn test
)