This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Make dev mode reflect changes to css #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antony
approved these changes
Aug 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you make a change to a css file the change isn't showing up. The issue was in the lines:
When a change was encountered it would push the updated code to the end of the array, but then we'd find the first version. I changed it to a map instead and it works now.
Ironically this was pretty much the only line of css handling that didn't change in #1415. This sounded like a new issue from the bug reporter in Discord, but I'm not quite sure why it wouldn't have been happening before since it didn't change. Possibly the duplicate CSS bug covered it up if the original CSS didn't change and the duplicate did.