Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

vastly better logging #158

Merged
merged 2 commits into from
Mar 4, 2018
Merged

vastly better logging #158

merged 2 commits into from
Mar 4, 2018

Conversation

Rich-Harris
Copy link
Member

...or 'that feeling when @lukeed has already solved your problem'. This substantially improves the logging:

  • warnings are actually shown (they were squelched before). Related: Warnings should be passed to webpack svelte-loader#35
  • errors and warnings are deduped (e.g. a component has a syntax error — we don't want to print the frame for both the server and the client compiler
  • invalidations are printed to the console
  • output is nicely colourised

There are lots of ways it could be improved further. It would be nice to separate server console logs from Sapper console logs, for example (some kind of split screen?). For people who want it, it would be nice to show the details of the webpack output. It would be very cool to integrate with something like Jarvis or electron-webpack-dashboard, though that might be tricky when there are multiple webpack configs. (Maybe it makes sense to have a dedicated Sapper electron app?) For now though, this is a decent leap forward.

@Rich-Harris Rich-Harris merged commit e91955f into master Mar 4, 2018
@Rich-Harris Rich-Harris deleted the logging branch March 4, 2018 20:49
@Rich-Harris Rich-Harris mentioned this pull request Mar 4, 2018
@lukeed
Copy link
Member

lukeed commented Mar 4, 2018

😅 happy to help lol. There's a plugin you can use directly if you want: webpack-messages -- I use that version personally.

Jarvis doesn't do multi compilers yet, but we can bang that out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants