Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Ensure CSS is applied to nested route layouts #1581

Merged
merged 5 commits into from
Oct 2, 2020

Conversation

rodoch
Copy link
Contributor

@rodoch rodoch commented Oct 2, 2020

Fixes #1579.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

rodoch added 4 commits October 2, 2020 20:12
Includes tests.
This reverts commit 5f44b0a.
This time, include the actual fix and not just the tests
@benmccann
Copy link
Member

Thanks for this! Would it be possible to put the test in the existing css test directory? I.e. copy the src/routes/nested/ directory into that project. Each new project we adds has to be compiled and start/stop a new server, so it will keep the tests faster if we minimize the number of test projects. If there's some conflict with the existing one then we wouldn't necessarily need to prioritize that though

@rodoch
Copy link
Contributor Author

rodoch commented Oct 2, 2020

No problem, that's done!

@benmccann benmccann merged commit de7a2cd into sveltejs:master Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS not applied to nested route layouts (server-rendered only)
2 participants