This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
When getTimings is exposed from rollup output the info. #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getTimings is exposed from rollup when `perf: true` is set in the rollup config. Previously there was no way to get this information from a customer's perspective. With this change, setting perf: true in the rollup config will now display this information to the command line when running `sapper dev`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTimingsis exposed from rollup whenperf: trueis set in the rollupconfig rollup/rollup@6913e39 . Previously there was no way to get this information from a
customer's perspective when using sapper in development mode or when building via
sapper build. This meant that if a customer wanted to understand why their build was slow they had not clear path forward.With this change, setting
perf: truein the rollup config will now displaythis information to the command line when running
sapper devandsapper build