This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Use consistent cache-control:max-age=600 for HTML pages #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a
cache-control:max-age=600
set forindex.html
, but nocache-control
header set for the HTML pages served from routes. This PR makes both of them consistently usemax-age:600
in production andno-cache
in development.In a future PR, I would like to make all of these cache-control headers configurable:
'max-age=31536000, immutable'
by default)index.html
('max-age=600'
by default)'max-age=0'
by default, see Set service-worker max-age to 0 #428)But for now I would settle for making them consistent. :)