This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Remove unnecessary index.html file serve #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, `/index.html` should no longer exist (outside of `sapper export`, which doesn't apply here). After sveltejs#525 was merged, we're now using `/service-worker-index.html`, but that's handled by `get_page_handler.ts`, not here. So this code is doing nothing.
|
The build failures don't seem related to this PR? |
Looking at the CI log, those are the same errors I get when running the tests on a fresh clone. Makes it a challenge to write a failing test for a PR I have in mind. |
|
thanks! yep, the build failures were related to a Rollup bug that's now fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
/index.htmlshould no longer exist (outside ofsapper export, which doesn't apply here). After #525 was merged, we're now using/service-worker-index.html, but that's handled byget_page_handler.ts, not here. So this code is doing nothing.