This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fixed %sapper.styles% injection for webpack apps #622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
Several month ago I've added
css
field tobuild.json
info file for webpack apps.The
css
field had a shape like:That time I didn't notice two things:
build_info.css[part.file]
. Because of the implementation described above used thewepackChunkName
to formccs.chunks
keys the styles were never added to%sapper.styles%
.css.chunks
values should be arrays not stringsThe PR fixes both of the issues described.