This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
give each app its own page, preloading and session stores, using context #642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #582.
To recap: we need a way to access
page
,preloading
andsession
inside an app — as stores — that's consistent between server and client. One way to do that is to export them from@sapper/app
directly, and rely on the fact that we can reset them immediately before server rendering to ensure that session data isn't accidentally leaked between two users accessing the same server.It's not future-proof, though. If at some point we support asynchronous or streaming rendering, it would be possible for an app to write to the
session
store in a way that could affect its value for a different user, if the other user readsession
asynchronously.The only solution that I can see is to ensure that each user gets their own set of stores for each server-rendered page. We can achieve this with the context API, and expose the stores like so:
Calling
stores()
outside component initialisation would be an error.