Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Explicitly load style-loader/css-loader deps #72

Merged
merged 1 commit into from
Jan 14, 2018

Conversation

nolanlawson
Copy link
Contributor

This appears to fix sveltejs/sapper-template#27. It's based on the proposed workaround in webpack-contrib/extract-text-webpack-plugin#456 (comment)

The downside is that the production size of main.js appears to increase from 4.2KB to 6.2KB. On the other hand... async style loading actually works. 😅 I don't see any more console errors while clicking around in the production app.

@nolanlawson
Copy link
Contributor Author

Hm, on second thought, this appears to fix the console errors but doesn't actually enable async style loading. I have some style in a subcomponent that isn't loaded when it's loaded asynchronously... this needs more investigation.

@nolanlawson
Copy link
Contributor Author

Nevermind, that other issue appears to be unrelated. I'll try to find a repro. In any case, this PR allows the app to actually load subpages, which is a more serious bug than not being able to load async styles.

@nolanlawson
Copy link
Contributor Author

Opened a separate issue, and it is indeed a separate issue: #79

@Rich-Harris Rich-Harris merged commit 133be03 into sveltejs:master Jan 14, 2018
@Rich-Harris
Copy link
Member

Thank you! Top sleuthing, not sure I would ever have figured that out. Seems a bit unfortunate, will have to see if there's a way around the extra bytes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'call' of undefined
2 participants