This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Allow export to take multiple entrypoints to use when crawling. #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to pass a list of entry points to export, which allows users to fully export apps that are not entirely linked by anchor tags.
I'm not sure if this is the best way to do it but it seems to work, I've added a test that provides a few unlinked entry points in the various styles people might try to pass in. I've done my best to handle unnecessary
index.htmls and/s (I'm no regex expert so that might need looking at). I also moved theoninfocall so users get a console message for each entry point, followed by the list of saved files for that 'crawl'.I added
.vscodeto the gitignore as I was having trouble disabling my autoformatting with out it. I don't know what has happened with thepackage-lock.jsonit just seems to add some stuff when I install it.Closes #749.